Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DigitalOutputs writeAll function logical operator #10

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

kevmk04
Copy link
Contributor

@kevmk04 kevmk04 commented Mar 18, 2024

Fixes #8 by switching to bitwise operator

@CLAassistant
Copy link

CLAassistant commented Mar 18, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

Memory usage change @ 4e43a36

Board flash % RAM for global variables %
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
Click for full report table
Board examples/Analog_Out
flash
% examples/Analog_Out
RAM for global variables
% examples/Analog_input/Analog_input_0_10V
flash
% examples/Analog_input/Analog_input_0_10V
RAM for global variables
% examples/Analog_input/Analog_input_4_20mA
flash
% examples/Analog_input/Analog_input_4_20mA
RAM for global variables
% examples/Analog_input/Analog_input_NTC
flash
% examples/Analog_input/Analog_input_NTC
RAM for global variables
% examples/Analog_input/Fast_Analog_input_0_10V
flash
% examples/Analog_input/Fast_Analog_input_0_10V
RAM for global variables
% examples/CAN/ReadCan
flash
% examples/CAN/ReadCan
RAM for global variables
% examples/CAN/WriteCan
flash
% examples/CAN/WriteCan
RAM for global variables
% examples/Digital_output
flash
% examples/Digital_output
RAM for global variables
% examples/Digital_programmable/Digital_input
flash
% examples/Digital_programmable/Digital_input
RAM for global variables
% examples/Digital_programmable/GPIO_programmable
flash
% examples/Digital_programmable/GPIO_programmable
RAM for global variables
% examples/Encoders
flash
% examples/Encoders
RAM for global variables
% examples/Ethernet
flash
% examples/Ethernet
RAM for global variables
% examples/RS232
flash
% examples/RS232
RAM for global variables
% examples/RS485_fullduplex
flash
% examples/RS485_fullduplex
RAM for global variables
% examples/RS485_halfduplex
flash
% examples/RS485_halfduplex
RAM for global variables
% examples/RTC
flash
% examples/RTC
RAM for global variables
% examples/RTC_Alarm
flash
% examples/RTC_Alarm
RAM for global variables
% examples/Temp_probes_RTD
flash
% examples/Temp_probes_RTD
RAM for global variables
% examples/Temp_probes_Thermocouples
flash
% examples/Temp_probes_Thermocouples
RAM for global variables
% examples/USB_host
flash
% examples/USB_host
RAM for global variables
%
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
Click for full report CSV
Board,examples/Analog_Out<br>flash,%,examples/Analog_Out<br>RAM for global variables,%,examples/Analog_input/Analog_input_0_10V<br>flash,%,examples/Analog_input/Analog_input_0_10V<br>RAM for global variables,%,examples/Analog_input/Analog_input_4_20mA<br>flash,%,examples/Analog_input/Analog_input_4_20mA<br>RAM for global variables,%,examples/Analog_input/Analog_input_NTC<br>flash,%,examples/Analog_input/Analog_input_NTC<br>RAM for global variables,%,examples/Analog_input/Fast_Analog_input_0_10V<br>flash,%,examples/Analog_input/Fast_Analog_input_0_10V<br>RAM for global variables,%,examples/CAN/ReadCan<br>flash,%,examples/CAN/ReadCan<br>RAM for global variables,%,examples/CAN/WriteCan<br>flash,%,examples/CAN/WriteCan<br>RAM for global variables,%,examples/Digital_output<br>flash,%,examples/Digital_output<br>RAM for global variables,%,examples/Digital_programmable/Digital_input<br>flash,%,examples/Digital_programmable/Digital_input<br>RAM for global variables,%,examples/Digital_programmable/GPIO_programmable<br>flash,%,examples/Digital_programmable/GPIO_programmable<br>RAM for global variables,%,examples/Encoders<br>flash,%,examples/Encoders<br>RAM for global variables,%,examples/Ethernet<br>flash,%,examples/Ethernet<br>RAM for global variables,%,examples/RS232<br>flash,%,examples/RS232<br>RAM for global variables,%,examples/RS485_fullduplex<br>flash,%,examples/RS485_fullduplex<br>RAM for global variables,%,examples/RS485_halfduplex<br>flash,%,examples/RS485_halfduplex<br>RAM for global variables,%,examples/RTC<br>flash,%,examples/RTC<br>RAM for global variables,%,examples/RTC_Alarm<br>flash,%,examples/RTC_Alarm<br>RAM for global variables,%,examples/Temp_probes_RTD<br>flash,%,examples/Temp_probes_RTD<br>RAM for global variables,%,examples/Temp_probes_Thermocouples<br>flash,%,examples/Temp_probes_Thermocouples<br>RAM for global variables,%,examples/USB_host<br>flash,%,examples/USB_host<br>RAM for global variables,%
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A

@leonardocavagnis leonardocavagnis self-requested a review March 19, 2024 09:15
Copy link
Contributor

@leonardocavagnis leonardocavagnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution! 🎉

@leonardocavagnis leonardocavagnis merged commit 4037165 into arduino-libraries:main Mar 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DigitalOutputs writeAll function not correctly writing to each Output
3 participants