-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make non-existent resource report raise 404 #11778
base: dev/7.6.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a changelog entry?
response = self.client.get(url) | ||
self.assertEqual(response.status_code, 200) | ||
|
||
def test_resource_report_bad(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because test_resource_report_good
tests if the status is 200, that name makes sense. In this case though, I think what's being tested isn't whether the response is bad (which I would take to mean a 500) but rather whether it's missing. So I think more intuitive name would be test_resource_report_for_missing_resource
or something like that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are other places where this should probably be applied as well such as the resource editor, but that could be done is a different PR.
This issue is already fixed in 8.0. Does it qualify for a 7.6 fix? |
…re #11772
Types of changes
Description of Change
Issues Solved
Closes #
Checklist
Accessibility Checklist
Developer Guide
Ticket Background
Further comments