Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return a 404 when /report/ or /resource/ doesn't lead to an existing resource #11772

Closed
whatisgalen opened this issue Feb 6, 2025 · 1 comment · May be fixed by #11778
Closed

Return a 404 when /report/ or /resource/ doesn't lead to an existing resource #11772

whatisgalen opened this issue Feb 6, 2025 · 1 comment · May be fixed by #11778
Assignees
@whatisgalen

Comments

@whatisgalen
Copy link
Member

In debug mode, the error you see when you try to go to a report for a non-existent resource is:

DoesNotExist at /report/edb83d95-543e-4d01-98b9-abdbd3212763

...which shows up as a 500 in production because the DoesNotExist exception is unhandled by the Report view. It should actually be a 404 since the resource sought was not found.
@chiatt chiatt added this to pipeline Feb 6, 2025
whatisgalen added a commit that referenced this issue Feb 10, 2025
@whatisgalen
put Resource orm query in try/except Resource.DoesNotExist handling, re
095f523 
#11772
@whatisgalen whatisgalen mentioned this issue Feb 10, 2025
Open
11 tasks
@whatisgalen whatisgalen linked a pull request Feb 10, 2025 that will close this issue
Make non-existent resource report raise 404 #11778
Open
11 tasks
@whatisgalen whatisgalen self-assigned this Feb 10, 2025
whatisgalen added a commit that referenced this issue Feb 10, 2025
@whatisgalen
create test for deleted resource report 404, re #11772
b0a4c7f
whatisgalen added a commit that referenced this issue Feb 10, 2025
@whatisgalen
use Resource proxy delete in test, re #11772
ca4c0f4
@jacobtylerwalls
Copy link
Member

Fixed in #11637

@github-project-automation github-project-automation bot moved this to ✅ Done in pipeline Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whatisgalen whatisgalen

Labels
None yet
Projects
pipeline
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make non-existent resource report raise 404 archesproject/arches
2 participants
@whatisgalen @jacobtylerwalls