Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filters for only search components that are enabled, re #10805 #10806

Closed
wants to merge 1 commit into from

Conversation

whatisgalen
Copy link
Member

@whatisgalen whatisgalen commented Apr 19, 2024

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

ensures that when SearchFilterFactory is instantiated, it only accepts search filters that are enabled

Issues Solved

#10805

Checklist

  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Ticket Background

Further comments

@whatisgalen whatisgalen requested a review from apeters May 3, 2024 04:30
whatisgalen added a commit that referenced this pull request May 9, 2024
@whatisgalen
Copy link
Member Author

Closing in favor of #10807

@whatisgalen whatisgalen closed this Jul 4, 2024
@whatisgalen whatisgalen deleted the 10805_search_filters_enabled branch July 4, 2024 01:01
@whatisgalen whatisgalen removed the request for review from apeters July 4, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SearchFilterFactory should only collect SearchComponents that are enabled=True
1 participant