Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SearchFilterFactory should only collect SearchComponents that are enabled=True #10805

Closed
whatisgalen opened this issue Apr 19, 2024 · 1 comment
Closed

SearchFilterFactory should only collect SearchComponents that are enabled=True #10805

whatisgalen opened this issue Apr 19, 2024 · 1 comment

Comments

@whatisgalen
Copy link
Member

In the base.py search component class, it instantiates a SearchFilterFactory with all search components without checking the property enabled (here)
@chiatt chiatt added this to pipeline Apr 19, 2024
whatisgalen added a commit that referenced this issue Apr 19, 2024
@whatisgalen
filters for only search components that are enabled, re #10805
75bf628
@whatisgalen whatisgalen mentioned this issue Apr 19, 2024
Closed
6 tasks
whatisgalen added a commit that referenced this issue Apr 19, 2024
@whatisgalen
filters for only search components that are enabled, re #10805
ecac100
@whatisgalen whatisgalen self-assigned this May 7, 2024
@whatisgalen whatisgalen linked a pull request May 11, 2024 that will close this issue
filters for only search components that are enabled, re #10805 #10806
Closed
6 tasks
@whatisgalen
Copy link
Member Author

closing this in anticipation of #10807 given that its migration includes the removal of the "enabled" field from the SearchComponent model

@github-project-automation github-project-automation bot moved this to ✅ Done in pipeline Jul 4, 2024
@whatisgalen whatisgalen removed their assignment Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
pipeline
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

filters for only search components that are enabled, re #10805 archesproject/arches
1 participant
@whatisgalen