Skip to content

Make parameters config optional in RawPyTorchMergeConfig. #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make parameters config optional in RawPyTorchMergeConfig. #630

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31aec62
Make parameters config optional in RawPyTorchMergeConfig.
mklimasz Sep 17, 2025
29206a4
Add check if config.parameters is null.
mklimasz Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions mergekit/scripts/merge_raw_pytorch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ class InputModelDefinition(BaseModel, frozen=True):

class RawPyTorchMergeConfig(BaseModel, frozen=True):
merge_method: str
parameters: Optional[Dict[str, ParameterSetting]]
models: List[InputModelDefinition]
parameters: Optional[Dict[str, ParameterSetting]] = None
dtype: Optional[str] = None
base_model: Optional[str] = None

Expand Down Expand Up @@ -169,7 +169,7 @@ def construct_param_dicts(
):
global_params = {}
for param_def in merge_method.parameters():
if param_def.name in config.parameters:
if config.parameters and param_def.name in config.parameters:
value = evaluate_setting(tensor_name, config.parameters[param_def.name])
if value is not None:
global_params[param_def.name] = value
Expand All @@ -192,7 +192,7 @@ def construct_param_dicts(
):
tensor_params[mr][param_def.name] = value
elif value := evaluate_setting(
tensor_name, config.parameters.get(param_def.name, [])
tensor_name, config.parameters.get(param_def.name, []) if config.parameters else []
):
tensor_params[mr][param_def.name] = value
elif param_def.required:
Expand Down