Skip to content

Make parameters config optional in RawPyTorchMergeConfig. #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make parameters config optional in RawPyTorchMergeConfig. #630

wants to merge 2 commits into from

Conversation

mklimasz
Copy link

In contrast to merge-yaml the merge-pytorch configuration has non-nullable parameters value (MergeConfiguration L99 vs RawPyTorchMergeConfig L31).

The change adds possibility to provide empty parameters value during merge-pytorch and passes all the tests.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2025 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@mklimasz
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@mklimasz
Copy link
Author

recheck

cursor[bot]

This comment was marked as outdated.

Sign in to view

@mklimasz mklimasz force-pushed the mergekit_pytorch_config_fix branch from 66eeec6 to 29206a4 Compare September 25, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cursor cursor[bot] cursor[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mklimasz