-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New endpoints + bug fixes #310
Open
scorpion35
wants to merge
14
commits into
arangamani:master
Choose a base branch
from
scorpion35:panne_all_queue_builds
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
58cdbf6
New endpoints
a3e06f7
Bug fix
8baa591
debug
47c57c5
Bug fix
59c00e0
Skip certificate check
4098068
Bug fix
085139c
Logging
925f7b9
Bug fix
533a9d0
No verify when no certificate is passed
c778acf
Bug fix
7eb63ca
Bug fix
b6e13ee
Removed logging
244aa69
Must've removed by mistake
20c403c
Documentation
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -114,7 +114,7 @@ class Client | |
def initialize(args) | ||
args = symbolize_keys(args) | ||
args.each do |key, value| | ||
if value && VALID_PARAMS.include?(key.to_s) | ||
if VALID_PARAMS.include?(key.to_s) | ||
instance_variable_set("@#{key}", value) | ||
end | ||
end if args.is_a? Hash | ||
|
@@ -363,7 +363,14 @@ def make_http_request(request, follow_redirect = @follow_redirects) | |
http.use_ssl = true | ||
|
||
http.verify_mode = OpenSSL::SSL::VERIFY_PEER | ||
http.ca_file = @ca_file if @ca_file | ||
|
||
if @ca_file | ||
http.ca_file = @ca_file | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. use 2-space indent |
||
else | ||
http.verify_mode = OpenSSL::SSL::VERIFY_NONE | ||
end | ||
else | ||
http.verify_mode = OpenSSL::SSL::VERIFY_NONE | ||
Comment on lines
+370
to
+373
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this seems like an unsafe default |
||
end | ||
http.open_timeout = @http_open_timeout | ||
http.read_timeout = @http_read_timeout | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did this change ?