New endpoints + bug fixes #310
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
June 5, 2021 21:40
|
@arangamani Opened my first PR on this repo. Let me know if you need more information please |
grosser
reviewed
Mar 20, 2023
| @@ -114,7 +114,7 @@ class Client | |||
| def initialize(args) | |||
| args = symbolize_keys(args) | |||
| args.each do |key, value| | |||
| if value && VALID_PARAMS.include?(key.to_s) | |||
grosser
reviewed
Mar 20, 2023
| http.ca_file = @ca_file if @ca_file | ||
|
|
||
| if @ca_file | ||
| http.ca_file = @ca_file |
grosser
reviewed
Mar 20, 2023
Comment on lines
+370
to
+373
| http.verify_mode = OpenSSL::SSL::VERIFY_NONE | ||
| end | ||
| else | ||
| http.verify_mode = OpenSSL::SSL::VERIFY_NONE |
There was a problem hiding this comment.
this seems like an unsafe default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new endpoints to get all items from the queue and build details for a specified build
And a couple of bug fixes -