SOLR-15873: factor out a ReRankRescorer class, simplify LTR[Interleaving]Rescorer code #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing]Rescorer code
This was referenced Dec 24, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Keeping this PR as "draft" whilst the "keep or not keep" discussion in SOLR-15873 is underway and also because this PR includes the #470 changes.)
https://issues.apache.org/jira/browse/SOLR-15873
The Lucene
Rescorer.rescoreAPI signature takes three arguments:rescore(IndexSearcher searcher, TopDocs firstPassTopDocs, int topN)The Solr
ReRankCollectorcaps the number of documents that are passed to therescoremethod so thattopN == firstPassTopDocs.scoreDocs.lengthis always the case.This pull request introduces a
ReRankRescorerclass for the specificReRankCollectoruse case i.e. a two arguments API signature variantrescore(IndexSearcher searcher, TopDocs firstPassTopDocs)with non-support of the three argument variant.Then the
LTR[Interleaving]Rescorerlogic can then be simplified by making use of thetopN == firstPassTopDocs.scoreDocs.lengthcondition.Existing
LTR[Interleaving]RescorerAPIs that supporttopN != firstPassTopDocs.scoreDocs.lengthare retained with@deprecatedannotation for backwards compatibility and with the intention to remove them in the next or a subsequent Solr version.