SOLR-15873: simplify LTR[Interleaving]Rescorer code #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpoerschke
commented
Dec 23, 2021
Comment on lines
-156
to
+153
| public void scoreFeatures(IndexSearcher indexSearcher, | ||
| int topN, LTRScoringQuery.ModelWeight modelWeight, ScoreDoc[] hits, List<LeafReaderContext> leaves, | ||
| private void scoreFeatures(IndexSearcher indexSearcher, | ||
| LTRScoringQuery.ModelWeight modelWeight, ScoreDoc[] hits, List<LeafReaderContext> leaves, |
There was a problem hiding this comment.
This here could be considered backwards incompatible (signature and behaviour change to a public method) but if #473 first marked the public method deprecated (in a prior Solr release) then it could be considered a backwards compatible change.
Comment on lines
-115
to
+112
| public void scoreFeatures(IndexSearcher indexSearcher, | ||
| int topN, LTRScoringQuery.ModelWeight[] modelWeights, ScoreDoc[] hits, List<LeafReaderContext> leaves, | ||
| private void scoreFeatures(IndexSearcher indexSearcher, | ||
| LTRScoringQuery.ModelWeight[] modelWeights, ScoreDoc[] hits, List<LeafReaderContext> leaves, |
There was a problem hiding this comment.
This here could be considered backwards incompatible (signature and behaviour change to a public method) but if #473 first marked the public method deprecated (in a prior Solr release) then it could be considered a backwards compatible change.
Comment on lines
+219
to
+221
| * @deprecated From Solr 9.2.0 onwards this method will be removed. | ||
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
This method is now unused but would be retained for (say) one Solr release for backwards compatibility.
This was referenced Dec 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Keeping this PR as "draft" whilst the "keep or not keep" discussion in SOLR-15873 is underway and also because this PR includes the #470 and #474 changes.)
https://issues.apache.org/jira/browse/SOLR-15873