Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use taiki-e/install-action to install tools from binary #852

Merged
merged 5 commits into from
Jan 4, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,12 @@ jobs:
- name: Check License Header
uses: apache/skywalking-eyes/[email protected]

- name: Install cargo-sort
run: make install-cargo-sort

- name: Install taplo-cli
run: make install-taplo-cli
uses: taiki-e/install-action@v2
with:
tool: [email protected]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump version to fix this issue
image

- name: Check toml format
run: make check-toml
Comment on lines +53 to +54
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously we only installed taplo, but didn't run it


- name: Cargo format
run: make check-fmt
Expand All @@ -61,11 +62,19 @@ jobs:
- name: Cargo clippy
run: make check-clippy

- name: Install cargo-sort
uses: taiki-e/install-action@v2
with:
tool: [email protected]
- name: Cargo sort
run: make cargo-sort
run: cargo sort -c -w
Comment on lines -65 to +70
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meet an installation error
image


- name: Install cargo-machete
uses: taiki-e/install-action@v2
with:
tool: cargo-machete
- name: Cargo Machete
run: make cargo-machete
run: cargo machete

build:
runs-on: ${{ matrix.os }}
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ cargo-machete: install-cargo-machete
cargo machete

install-taplo-cli:
cargo install [email protected].0
cargo install [email protected].3

fix-toml: install-taplo-cli
taplo fmt
Expand Down
Loading