ci: use taiki-e/install-action to install tools from binary #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of compiling from source need to wait for INFRA approval https://issues.apache.org/jira/browse/INFRA-26400 Signed-off-by: xxchan <xxchan22f@gmail.com>
xxchan
commented
Dec 27, 2024
Comment on lines
+53
to
+54
| - name: Check toml format | ||
| run: make check-toml |
There was a problem hiding this comment.
Previously we only installed taplo, but didn't run it
Signed-off-by: xxchan <xxchan22f@gmail.com>
|
INFRA has approved the action |
xxchan
commented
Jan 3, 2025
| run: make install-taplo-cli | ||
| uses: taiki-e/install-action@v2 | ||
| with: | ||
| tool: taplo-cli@0.9.3 |
There was a problem hiding this comment.
Bump version to fix this issue
Signed-off-by: xxchan <xxchan22f@gmail.com>
xxchan
commented
Jan 3, 2025
Comment on lines
-65
to
+70
| run: make cargo-sort | ||
| run: cargo sort -c -w |
There was a problem hiding this comment.
meet an installation error
Signed-off-by: xxchan <xxchan22f@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of compiling from source
need to wait for INFRA approval https://issues.apache.org/jira/browse/INFRA-26400