HIVE-28846: change default value of ifExist in dropCatalogRequest to … #5713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the DropCatalogRequest default behavior so that its ifExists flag now defaults to true, preventing exceptions when dropping a non-existent catalog.
- Updated default value for ifExists in generated Thrift files for Python, Ruby, and JavaBean.
- Adjusted tests in TestCatalogs.java to differentiate behavior when ifExists is false versus true.
Reviewed Changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py | Updated default value for ifExists in Python generated code |
| standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb | Updated default value for ifExists in Ruby generated code |
| standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/DropCatalogRequest.java | Set default ifExists to true in constructor and clear method |
| standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestCatalogs.java | Modified tests to reflect the new behavior for dropCatalog |
Files not reviewed (3)
- standalone-metastore/metastore-common/src/gen/thrift/gen-cpp/hive_metastore_types.h: Language not supported
- standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/DropCatalogRequest.php: Language not supported
- standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift: Language not supported
Comments suppressed due to low confidence (1)
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestCatalogs.java:202
- [nitpick] The use of Assert.assertTrue with a constant true is redundant given the @test(expected = ...) annotation. Consider removing or replacing it with a fail() call to make the test intent clearer if no exception is thrown.
Assert.assertTrue("dropCatalog completed without throwing an exception", true);
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…be true
What changes were proposed in this pull request?
Set ifExist default value to be true in DropCatalogRequest
Why are the changes needed?
This is a follow-up improvement for the ticket: https://issues.apache.org/jira/browse/HIVE-28443
Set ifExist default value to be true to ensure it doesn't throw exception.
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
Unit test added