HIVE-28846: Change default value of ifExist in dropCatalogRequest to be true (#5713) (Hazel Jiang, Reviewed by Butao Zhang)

Co-authored-by: Your Name <[email protected]>

Author: jjiang037

standalone-metastore/metastore-common/src/gen/thrift/gen-cpp/hive_metastore_types.h

@@ -418,7 +418,7 @@ struct GetCatalogsResponse {
 
 struct DropCatalogRequest {
   1: string name,
-  2: optional bool ifExists
+  2: optional bool ifExists = true
 }
 
 // namespace for tables

standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/DropCatalogRequest.java

@@ -197,16 +197,17 @@ public void createCatalogWithBadLocation() throws TException {
 
   @Test(expected = NoSuchObjectException.class)
   public void dropNonExistentCatalog() throws TException {
-    client.dropCatalog("noSuchCatalog");
+    // If explicitly set to false, we expect an exception
+    client.dropCatalog("noSuchCatalog", false);
+    Assert.assertTrue("dropCatalog completed without throwing an exception", true);
   }
 
   @Test
-  public void dropNonExistentCatalogIfExists() throws TException {
-    client.dropCatalog("noSuchCatalog", true);
-    Assert.assertTrue("dropCatalog completed without throwing an exception", true);
+  public void dropCatalogIfExists() throws TException {
+    // With the default ifExists value of true, no exception should be thrown even if the catalog doesn't exist.
+    client.dropCatalog("noSuchCatalog");
   }
 
-
   @Test(expected = MetaException.class)
   public void dropHiveCatalog() throws TException {
     client.dropCatalog(Warehouse.DEFAULT_CATALOG_NAME);