Geb 8

[matrei]

Closes #15065

[matrei]

@JonasPammer Would you like to look over these changes?

[JonasPammer]

now this is what i call generics, haha. I would not even know half of these functions and groovy/thread-nanigans, especially after having used solely django at work for last few months. 🤫 😜

as long as the system env is set for when https://github.com/apache/groovy-geb/blob/4266eeeea6f59e4718339b93283327bf176563b9/module/geb-core/src/main/groovy/geb/Browser.groovy#L172 is called its still the same thing as my original thought/impl. 👍

[matrei]

now this is what i call generics, haha. I would not even know half of these functions and groovy/thread-nanigans, especially after having used solely django at work for last few months. 🤫 😜

as long as the system env is set for when https://github.com/apache/groovy-geb/blob/4266eeeea6f59e4718339b93283327bf176563b9/module/geb-core/src/main/groovy/geb/Browser.groovy#L172 is called its still the same thing as my original thought/impl. 👍

Haha, I thought it might be overkill as well, but what if you mix ContainerGebSpec and regular GebSpec tests in the same project?

However, I don't think our GebConfig integration is working perfectly yet. I tried switching to new RemoteWebDriver(new FirefoxOptions()) and it blows up as the container is browser specific and seems to default to chrome.

Could not start a new session. Response code 500. Message: Could not start a new session. No nodes support the capabilities in the request
Host info: host: 'f1b81917b1f3', ip: '172.17.0.4'
Build info: version: '4.34.0', revision: '2a4c61c498'
System info: [os.name](http://os.name/): 'Linux', os.arch: 'amd64', os.version: '6.10.14-linuxkit', java.version: '21.0.8'
Driver info: driver.version: unknown
Build info: version: '4.34.0', revision: '707dcb4246*'
System info: [os.name](http://os.name/): 'Linux', os.arch: 'amd64', os.version: '6.8.0-79-generic', java.version: '17.0.14'
Driver info: org.openqa.selenium.remote.RemoteWebDriver
Command: [null, newSession {capabilities=[Capabilities {acceptInsecureCerts: true, browserName: firefox, grails:gebConfigUsed: true, moz:firefoxOptions: {prefs: {remote.active-protocols: 1}}}]}]
Capabilities {acceptInsecureCerts: true, browserName: firefox, grails:gebConfigUsed: true, moz:firefoxOptions: {prefs: {remote.active-protocols: 1}}}
org.openqa.selenium.SessionNotCreatedException: Could not start a new session. Response code 500. Message: Could not start a new session. No nodes support the capabilities in the request

This is now fixed in fcc4d82

[JonasPammer]

Great Thanks

[jdaugherty]

Great Job! Only minor comments ...