Skip to content

Commit 93a3259

Browse files
committed
ci: feedback - set atCheckWaiting in build file
1 parent 933057b commit 93a3259

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

.github/workflows/gradle.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -173,14 +173,12 @@ jobs:
173173
with:
174174
develocity-access-key: ${{ secrets.GRAILS_DEVELOCITY_ACCESS_KEY }}
175175
- name: "🏃 Run Functional Tests"
176-
env:
177-
# Make Geb tests more resilient in slow CI environments
178-
JAVA_TOOL_OPTIONS: -Dgrails.geb.atCheckWaiting.enabled=true
179176
run: >
180177
./gradlew bootJar check
181178
--continue
182179
--rerun-tasks
183180
--stacktrace
181+
-PgebAtCheckWaiting
184182
-PonlyFunctionalTests
185183
-PskipCodeStyle
186184
-PskipHibernate5Tests

DEVELOPMENT.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ These can be set on the command line like so:
3131

3232
`./gradlew check -PskipCodeStyle`
3333

34+
* `gebAtCheckWaiting` - enables Geb atCheckWaiting
3435
* `onlyCoreTests` - runs tests that do not include mongo, hibernate, or functional
3536
* `onlyFunctionalTests` - runs only grails-test-examples/* tests
3637
* `onlyHibernate5Tests` - runs only a hibernate5 related test

gradle/functional-test-config.gradle

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,11 @@ tasks.withType(Test).configureEach { Test task ->
113113
if (System.getProperty('debug.tests')) {
114114
task.jvmArgs += debugArguments
115115
}
116+
117+
// Make Geb tests more resilient in slow CI environments
118+
if (project.hasProperty('gebAtCheckWaiting')) {
119+
systemProperty('grails.geb.atCheckWaiting.enabled', 'true')
120+
}
116121
}
117122

118123
tasks.named('groovydoc').configure {

0 commit comments

Comments
 (0)