Skip to content

[VL] Adjust Spark 4.x inherited suite coverage #12484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zml1206 merged 2 commits into from
Jul 13, 2026
+16 −10
Merged

[VL] Adjust Spark 4.x inherited suite coverage #12484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8a2751
[VL] Adjust Spark 4.x inherited suite coverage
zml1206 Jul 9, 2026
55917ea
Merge branch 'main' into 4.x
zml1206 Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,17 +234,20 @@ class VeloxTestSettings extends BackendTestSettings {
enableSuite[GlutenCsvExpressionsSuite]
enableSuite[GlutenDynamicPruningSubquerySuite]
enableSuite[GlutenExprIdSuite]
// TODO: 4.x enableSuite[GlutenExpressionEvalHelperSuite] // 2 failures
// GlutenExpressionEvalHelperSuite is not enabled: it validates Spark's ExpressionEvalHelper
// contract, while Gluten overrides checkEvaluation/checkExceptionInExpression.
enableSuite[GlutenExpressionImplUtilsSuite]
enableSuite[GlutenExpressionSQLBuilderSuite]
enableSuite[GlutenExpressionSetSuite]
enableSuite[GlutenExtractPredicatesWithinOutputSetSuite]
enableSuite[GlutenHexSuite]
enableSuite[GlutenMutableProjectionSuite]
enableSuite[GlutenNamedExpressionSuite]
// TODO: 4.x enableSuite[GlutenObjectExpressionsSuite] // 7 failures
// GlutenObjectExpressionsSuite is not enabled: object/encoder interpreted execution is
// JVM-side coverage and currently fails under Gluten's expression evaluation harness.
enableSuite[GlutenOrderingSuite]
// TODO: 4.x enableSuite[GlutenScalaUDFSuite] // 1 failure
// GlutenScalaUDFSuite is not enabled: ScalaUDF executes on the JVM/fallback path, so
// this parent suite has limited Velox coverage value and still has one inherited failure.
enableSuite[GlutenSchemaPruningSuite]
enableSuite[GlutenSelectedFieldSuite]
// GlutenSubExprEvaluationRuntimeSuite is removed because SubExprEvaluationRuntimeSuite
Expand Down
17 changes: 10 additions & 7 deletions gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ class VeloxTestSettings extends BackendTestSettings {
.exclude("random")
.exclude("SPARK-9127 codegen with long seed")
enableSuite[GlutenRegexpExpressionsSuite]
// TODO: fix on Spark-4.1 introduced by https://github.com/apache/spark/pull/48470
// TODO: fix after https://github.com/facebookincubator/velox/pull/17327
.exclude("SPLIT")
enableSuite[GlutenSortShuffleSuite]
enableSuite[GlutenSortOrderExpressionsSuite]
Expand All @@ -239,21 +239,24 @@ class VeloxTestSettings extends BackendTestSettings {
enableSuite[GlutenCodeGenerationSuite]
enableSuite[GlutenCodeGeneratorWithInterpretedFallbackSuite]
enableSuite[GlutenCollationExpressionSuite]
// TODO: 4.x enableSuite[GlutenCollationRegexpExpressionsSuite] // 1 failure
// TODO: 4.x enableSuite[GlutenCollationRegexpExpressionsSuite] // fix after https://github.com/facebookincubator/velox/pull/17327
enableSuite[GlutenCsvExpressionsSuite]
enableSuite[GlutenDynamicPruningSubquerySuite]
enableSuite[GlutenExprIdSuite]
// TODO: 4.x enableSuite[GlutenExpressionEvalHelperSuite] // 2 failures
// GlutenExpressionEvalHelperSuite is not enabled: it validates Spark's ExpressionEvalHelper
// contract, while Gluten overrides checkEvaluation/checkExceptionInExpression.
enableSuite[GlutenExpressionImplUtilsSuite]
enableSuite[GlutenExpressionSQLBuilderSuite]
enableSuite[GlutenExpressionSetSuite]
enableSuite[GlutenExtractPredicatesWithinOutputSetSuite]
enableSuite[GlutenHexSuite]
enableSuite[GlutenMutableProjectionSuite]
enableSuite[GlutenNamedExpressionSuite]
// TODO: 4.x enableSuite[GlutenObjectExpressionsSuite] // 7 failures
// TODO: 4.x enableSuite[GlutenOrderingSuite] // 2 failures
// TODO: 4.x enableSuite[GlutenScalaUDFSuite] // 1 failure
// GlutenObjectExpressionsSuite is not enabled: object/encoder interpreted execution is
// JVM-side coverage and currently fails under Gluten's expression evaluation harness.
enableSuite[GlutenOrderingSuite]
// GlutenScalaUDFSuite is not enabled: ScalaUDF executes on the JVM/fallback path, so
// this parent suite has limited Velox coverage value and still has one inherited failure.
enableSuite[GlutenSchemaPruningSuite]
enableSuite[GlutenSelectedFieldSuite]
// GlutenSubExprEvaluationRuntimeSuite is removed because SubExprEvaluationRuntimeSuite
Expand Down Expand Up @@ -696,7 +699,7 @@ class VeloxTestSettings extends BackendTestSettings {
enableSuite[GlutenGlobalTempViewSuite]
enableSuite[GlutenGlobalTempViewTestSuite]
enableSuite[GlutenGroupedIteratorSuite]
// TODO: 4.x enableSuite[GlutenHiveResultSuite] // 1 failure
enableSuite[GlutenHiveResultSuite]
enableSuite[GlutenInsertSortForLimitAndOffsetSuite]
.exclude("root LIMIT preserves data ordering with top-K sort")
.exclude("middle LIMIT preserves data ordering with top-K sort")
Expand Down
Loading