[VL] Adjust Spark 4.x inherited suite coverage#12484
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Velox backend Spark 4.0/4.1 inherited test suite settings to expand coverage where suites are now compatible with Gluten/Velox, while documenting why certain JVM-focused parent suites remain disabled.
Changes:
- Spark 4.1: enable additional inherited suites (
GlutenOrderingSuite,GlutenHiveResultSuite) to increase coverage. - Spark 4.0/4.1: refine inline rationale/comments for keeping some inherited suites disabled (e.g., ExpressionEvalHelper/ObjectExpressions/ScalaUDF), and update TODO references for known Velox issues.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala | Enables a couple more inherited Spark 4.1 suites and clarifies why several JVM-side validation suites remain disabled. |
| gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala | Adds consistent explanatory comments for intentionally disabled inherited suites. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Failed CI is irrelevant. |
Member
|
the failure should be fixed by #12487 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts the Velox Spark 4.0 and Spark 4.1 inherited suite settings.
It enables inherited Spark suites that are compatible with Gluten/Velox, and keeps several inherited suites disabled when they mainly validate Spark's JVM-side helper/object/UDF behavior rather than Gluten columnar execution.