Skip to content

[VL] Remove unused parameters in shuffle reader #11285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marin-ma merged 1 commit into from
Dec 14, 2025
Merged

[VL] Remove unused parameters in shuffle reader #11285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions cpp/velox/shuffle/VeloxShuffleReader.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,22 +444,16 @@ VeloxHashShuffleReaderDeserializer::VeloxHashShuffleReaderDeserializer(
const std::shared_ptr<arrow::Schema>& schema,
const std::shared_ptr<arrow::util::Codec>& codec,
const facebook::velox::RowTypePtr& rowType,
int32_t batchSize,
int64_t readerBufferSize,
VeloxMemoryManager* memoryManager,
std::vector<bool>* isValidityBuffer,
bool hasComplexType,
int64_t& deserializeTime,
int64_t& decompressTime)
: streamReader_(streamReader),
schema_(schema),
codec_(codec),
rowType_(rowType),
batchSize_(batchSize),
readerBufferSize_(readerBufferSize),
memoryManager_(memoryManager),
isValidityBuffer_(isValidityBuffer),
hasComplexType_(hasComplexType),
deserializeTime_(deserializeTime),
decompressTime_(decompressTime) {}

Expand Down Expand Up @@ -838,11 +832,8 @@ std::unique_ptr<ColumnarBatchIterator> VeloxShuffleReaderDeserializerFactory::cr
schema_,
codec_,
rowType_,
batchSize_,
readerBufferSize_,
memoryManager_,
&isValidityBuffer_,
hasComplexType_,
deserializeTime_,
decompressTime_);
case ShuffleWriterType::kSortShuffle:
Expand Down
8 changes: 0 additions & 8 deletions cpp/velox/shuffle/VeloxShuffleReader.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,8 @@ class VeloxHashShuffleReaderDeserializer final : public ColumnarBatchIterator {
const std::shared_ptr<arrow::Schema>& schema,
const std::shared_ptr<arrow::util::Codec>& codec,
const facebook::velox::RowTypePtr& rowType,
int32_t batchSize,
int64_t readerBufferSize,
VeloxMemoryManager* memoryManager,
std::vector<bool>* isValidityBuffer,
bool hasComplexType,
int64_t& deserializeTime,
int64_t& decompressTime);

Expand All @@ -53,20 +50,15 @@ class VeloxHashShuffleReaderDeserializer final : public ColumnarBatchIterator {
std::shared_ptr<arrow::Schema> schema_;
std::shared_ptr<arrow::util::Codec> codec_;
facebook::velox::RowTypePtr rowType_;
int32_t batchSize_;
int64_t readerBufferSize_;
VeloxMemoryManager* memoryManager_;

std::vector<bool>* isValidityBuffer_;
bool hasComplexType_;

int64_t& deserializeTime_;
int64_t& decompressTime_;

std::shared_ptr<arrow::io::InputStream> in_{nullptr};

bool reachedEos_{false};
bool blockTypeResolved_{false};

std::vector<int32_t> dictionaryFields_{};
std::vector<facebook::velox::VectorPtr> dictionaries_{};
Expand Down