[VL] Remove unused parameters in shuffle reader#11285
Merged
Merged
Conversation
xinghuayu007
changed the title
xinghuayu007
force-pushed
the
my/remove_unused_code
branch
from
December 12, 2025 02:04
8507f38 to
2b6b1bc
Compare
philo-he
changed the title
philo-he
changed the title
Member
|
Just revised PR title to remove PR ID reference. |
philo-he
approved these changes
Dec 12, 2025
marin-ma
approved these changes
Dec 14, 2025
marin-ma
left a comment
marin-ma
left a comment
Contributor
There was a problem hiding this comment.
Yes. These params are not used after the merging has been removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Remove unused parameters.
How was this patch tested?