[VL] Add page load time metric#10294
Merged
Merged
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
rui-mo
force-pushed
the
wip_page_metric
branch
4 times, most recently
from
daa5889 to
12519b3
Compare
rui-mo
force-pushed
the
wip_page_metric
branch
2 times, most recently
from
62e2c1f to
b57ce1e
Compare
rui-mo
force-pushed
the
wip_page_metric
branch
2 times, most recently
from
6f10f66 to
f4c1ba6
Compare
Contributor
|
@rui-mo can you split the PR and add the two metrics in adance? "dataSourceAddSplitTime" -> SQLMetrics.createNanoTimingMetric(
sparkContext,
"data source add split time"),
"dataSourceReadTime" -> SQLMetrics.createNanoTimingMetric(
sparkContext,
"data source read time"), |
Contributor
|
depends on facebookincubator/velox#14587 |
Contributor
|
@rui-mo can you rebase the PR since facebookincubator/velox#14587 is merged? |
rui-mo
force-pushed
the
wip_page_metric
branch
from
f4c1ba6 to
408fa22
Compare
FelixYBW
approved these changes
Oct 22, 2025
FelixYBW
added a commit
to FelixYBW/gluten
that referenced
this pull request
Apr 20, 2026
This commit adds a new metric 'storageReads' that counts the number of storage read operations, complementing the existing 'storageReadBytes' metric which tracks the total bytes read. Changes: - Java: Added storageReads field to Metrics.java and OperatorMetrics.java - Scala: Added storageReads metric definition in VeloxMetricsApi.scala - Scala: Updated BatchScanMetricsUpdater to populate the metric - C++: Added kStorageReads to Metrics enum in Metrics.h - C++: Updated JniWrapper.cc to pass the metric to Java - C++: Updated WholeStageResultIterator.cc to collect the metric using 'count' aggregation on kStorageReadBytes runtime stat Metric type: SQLMetrics.createMetric (count-based) Follows the pattern from PR apache#10294 (pageLoadTime metric)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The time spent in page load is useful for the table scan profiling, and this PR adds the page load time metric.
How was this patch tested?
UT