[VL] Add storageReads metric to track number of storage read operations#11964
Merged
Conversation
FelixYBW
force-pushed
the
add_loads_count_metric
branch
from
1ed3bf8 to
6afc71e
Compare
This commit adds a new metric 'storageReads' that counts the number of storage read operations, complementing the existing 'storageReadBytes' metric which tracks the total bytes read. Changes: - Java: Added storageReads field to Metrics.java and OperatorMetrics.java - Scala: Added storageReads metric definition in VeloxMetricsApi.scala - Scala: Updated BatchScanMetricsUpdater to populate the metric - C++: Added kStorageReads to Metrics enum in Metrics.h - C++: Updated JniWrapper.cc to pass the metric to Java - C++: Updated WholeStageResultIterator.cc to collect the metric using 'count' aggregation on kStorageReadBytes runtime stat Metric type: SQLMetrics.createMetric (count-based) Follows the pattern from PR apache#10294 (pageLoadTime metric)
FelixYBW
force-pushed
the
add_loads_count_metric
branch
from
6afc71e to
c2fd9e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a new metric 'storageReads' that counts the number of storage read operations, complementing the existing 'storageReadBytes' metric which tracks the total bytes read.
Changes:
Metric type: SQLMetrics.createMetric (count-based) Follows the pattern from PR #10294 (pageLoadTime metric)
Was this patch authored or co-authored using generative AI tooling?
Yes