Skip to content

build: reduce overhead of fuzz testing #3257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbutrovich merged 6 commits into from
Jan 26, 2026
Merged

build: reduce overhead of fuzz testing #3257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c4a9149
build: reduce overhead of fuzz testing
andygrove Jan 23, 2026
fbc8516
make workflow names consistent
andygrove Jan 23, 2026
2cb5f99
Merge remote-tracking branch 'apache/main' into better-cheaper-faster…
andygrove Jan 24, 2026
e87af12
upmerge
andygrove Jan 26, 2026
e185219
Merge remote-tracking branch 'apache/main' into better-cheaper-faster…
andygrove Jan 26, 2026
69876d0
fix
andygrove Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/pr_build_linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,27 +169,27 @@ jobs:
- name: "Spark 3.5.5, JDK 17, Scala 2.13"
java_version: "17"
maven_opts: "-Pspark-3.5 -Dspark.version=3.5.5 -Pscala-2.13"
scan_impl: "native_comet"
scan_impl: "auto"

- name: "Spark 3.5.6, JDK 17, Scala 2.13"
java_version: "17"
maven_opts: "-Pspark-3.5 -Dspark.version=3.5.6 -Pscala-2.13"
scan_impl: "native_comet"

- name: "Spark 3.5, JDK 17, Scala 2.12 native_datafusion"
- name: "Spark 3.5, JDK 17, Scala 2.12"
java_version: "17"
maven_opts: "-Pspark-3.5 -Pscala-2.12"
scan_impl: "native_datafusion"

- name: "Spark 3.5, JDK 17, Scala 2.12 native_iceberg_compat"
- name: "Spark 3.5, JDK 17, Scala 2.12"
java_version: "17"
maven_opts: "-Pspark-3.5 -Pscala-2.12"
scan_impl: "native_iceberg_compat"

- name: "Spark 4.0, JDK 17"
java_version: "17"
maven_opts: "-Pspark-4.0"
scan_impl: "native_comet"
scan_impl: "auto"
Copy link
Member Author

@andygrove andygrove Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have only been testing Spark 4 with the native_comet scan as the default 🤦

suite:
- name: "fuzz"
value: |
Expand Down Expand Up @@ -267,7 +267,7 @@ jobs:
value: |
org.apache.spark.sql.CometToPrettyStringSuite
fail-fast: false
name: ${{ matrix.os }}/${{ matrix.profile.name }} [${{ matrix.suite.name }}]
name: ${{ matrix.os }}/${{ matrix.profile.name }}/${{ matrix.profile.scan_impl }} [${{ matrix.suite.name }}]
runs-on: ${{ matrix.os }}
container:
image: amd64/rust
Expand Down
17 changes: 5 additions & 12 deletions spark/src/test/scala/org/apache/comet/CometFuzzTestBase.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,18 +112,11 @@ class CometFuzzTestBase extends CometTestBase with AdaptiveSparkPlanHelper {
override protected def test(testName: String, testTags: Tag*)(testFun: => Any)(implicit
pos: Position): Unit = {
Seq("native", "jvm").foreach { shuffleMode =>
Seq(
CometConf.SCAN_AUTO,
CometConf.SCAN_NATIVE_COMET,
CometConf.SCAN_NATIVE_DATAFUSION,
CometConf.SCAN_NATIVE_ICEBERG_COMPAT).foreach { scanImpl =>
super.test(testName + s" ($scanImpl, $shuffleMode shuffle)", testTags: _*) {
withSQLConf(
CometConf.COMET_NATIVE_SCAN_IMPL.key -> scanImpl,
CometConf.COMET_PARQUET_UNSIGNED_SMALL_INT_CHECK.key -> "false",
CometConf.COMET_SHUFFLE_MODE.key -> shuffleMode) {
testFun
}
super.test(testName + s" ($shuffleMode shuffle)", testTags: _*) {
withSQLConf(
CometConf.COMET_PARQUET_UNSIGNED_SMALL_INT_CHECK.key -> "false",
CometConf.COMET_SHUFFLE_MODE.key -> shuffleMode) {
testFun
}
}
}
Expand Down
Loading