Skip to content

Conversation

@andygrove
Copy link
Member

@andygrove andygrove commented Jan 23, 2026

Which issue does this PR close?

N/A

Rationale for this change

CI runs the PR builds with the default native scan implementation specified in the workflow, for example:

- name: "Spark 3.5.6, JDK 17, Scala 2.13"
  java_version: "17"
  maven_opts: "-Pspark-3.5 -Dspark.version=3.5.6 -Pscala-2.13"
  scan_impl: "native_comet"

In CometFuzzTestBase, we were running each test once for each scan implementation. This was redundant.

What changes are included in this PR?

  • CometFuzzTestBase uses the default scan impl.
  • Update the Linux CI workflow to have one run in auto mode. This was missing.

How are these changes tested?

@andygrove andygrove marked this pull request as ready for review January 23, 2026 20:06
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.13%. Comparing base (f09f8af) to head (69876d0).
⚠️ Report is 888 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3257      +/-   ##
============================================
+ Coverage     56.12%   60.13%   +4.00%     
- Complexity      976     1457     +481     
============================================
  Files           119      175      +56     
  Lines         11743    16085    +4342     
  Branches       2251     2665     +414     
============================================
+ Hits           6591     9672    +3081     
- Misses         4012     5066    +1054     
- Partials       1140     1347     +207     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

java_version: "17"
maven_opts: "-Pspark-4.0"
scan_impl: "native_comet"
scan_impl: "auto"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have only been testing Spark 4 with the native_comet scan as the default 🤦

Copy link
Contributor

@mbutrovich mbutrovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andygrove!

@mbutrovich mbutrovich merged commit b8c5275 into apache:main Jan 26, 2026
130 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants