Skip to content

Conversation

@YanivKunda
Copy link
Contributor

Which issue does this PR close?

Closes #1857

Rationale for this change

Spark 3.5.6 is the latest stable 3.5.x version, and should be supported.

What changes are included in this PR?

Just the upgrade of spark 3.5.5 to 3.5.6.
The ShimCometScanExec changes done for the 3.5.4 -> 3.5.5 upgrade in #1565 and #1573 still work because the referenced spark code hasn't changed.

How are these changes tested?

Ran mvn test with the spark-3.5 profile.

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.40%. Comparing base (f09f8af) to head (c76bb1c).
Report is 249 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1861      +/-   ##
============================================
+ Coverage     56.12%   59.40%   +3.27%     
- Complexity      976     1151     +175     
============================================
  Files           119      130      +11     
  Lines         11743    12667     +924     
  Branches       2251     2376     +125     
============================================
+ Hits           6591     7525     +934     
+ Misses         4012     3930      -82     
- Partials       1140     1212      +72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@YanivKunda
Copy link
Contributor Author

Rebased latest changes and updated diff file (missing IgnoreComet)

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @YanivKunda

@andygrove andygrove merged commit b515b34 into apache:main Jun 9, 2025
85 checks passed
@YanivKunda YanivKunda deleted the spark-3.5.6 branch June 9, 2025 21:41
coderfender pushed a commit to coderfender/datafusion-comet that referenced this pull request Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to spark-3.5.6

4 participants