-
Notifications
You must be signed in to change notification settings - Fork 267
fix: Remove COMET_SHUFFLE_FALLBACK_TO_COLUMNAR hack #1865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove COMET_SHUFFLE_FALLBACK_TO_COLUMNAR hack #1865
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1865 +/- ##
============================================
+ Coverage 56.12% 59.38% +3.26%
- Complexity 976 1150 +174
============================================
Files 119 130 +11
Lines 11743 12661 +918
Branches 2251 2375 +124
============================================
+ Hits 6591 7519 +928
+ Misses 4012 3930 -82
- Partials 1140 1212 +72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
For the cases where we were falling back to columnar, the tests now fail (and are ignored), or are we falling back to Spark? |
Previously, we were falling back to Spark because we didn't support native shuffle. Now we are falling back to columnar shuffle instead, making more queries run natively, hence uncovering more bugs. The main bug remaining is related to DPP and exchange re-use. |
|
Thanks for the reviews @parthchandra and @Kontinuation. I will need to rebase this PR and update the 3.5.6 diff now that #1861 is merged. |
Which issue does this PR close?
Part of #1254
Closes #1252
Closes #1824
Rationale for this change
The config
COMET_SHUFFLE_FALLBACK_TO_COLUMNARwas added as a hack so that we could avoid fixing some failing Spark SQL tests. However, the failing tests are real issues and only show up now because more queries are running natively.What changes are included in this PR?
This PR removes the hack and updates the diff files to either fix or ignore failing tests. Some of these tests will be enabled later as part of #1254.
How are these changes tested?