Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ruby/red-arrow-format/lib/arrow-format/type.rb
Original file line number Diff line number Diff line change
Expand Up @@ -463,6 +463,12 @@ def initialize(bit_width, unit)
@unit = unit
end

def ==(other)
other.is_a?(self.class) and
@bit_width == other.bit_width and
@unit == other.unit
end

def to_s
"#{super}(#{unit})"
end
Expand Down
30 changes: 30 additions & 0 deletions ruby/red-arrow-format/test/test-time32-type.rb

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you split this to test-time32-type.rb to test-time64-type.rb? We may add more tests to them later.

Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.

class TestTimeType < Test::Unit::TestCase
sub_test_case("Time32Type#==") do
def test_equal
assert_equal(ArrowFormat::Time32Type.new(:second),
ArrowFormat::Time32Type.new(:second))
end

def test_not_equal
assert_not_equal(ArrowFormat::Time32Type.new(:second),
ArrowFormat::Time32Type.new(:millisecond))
end
end
end
30 changes: 30 additions & 0 deletions ruby/red-arrow-format/test/test-time64-type.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.

class TestTime64Type < Test::Unit::TestCase
sub_test_case("#==") do
def test_equal
assert_equal(ArrowFormat::Time64Type.new(:microsecond),
ArrowFormat::Time64Type.new(:microsecond))
end

def test_not_equal
assert_not_equal(ArrowFormat::Time64Type.new(:microsecond),
ArrowFormat::Time64Type.new(:nanosecond))
end
end
end
Loading