GH-50455: [Ruby] Add ArrowFormat::TimeType#==#50461
Merged
Merged
Conversation
|
|
kou
approved these changes
Jul 10, 2026
Member
There was a problem hiding this comment.
Could you split this to test-time32-type.rb to test-time64-type.rb? We may add more tests to them later.
github-actions
Bot
added
awaiting merge
Signed-off-by: Aaditya Srinivasan <aadityasri03@gmail.com>
Reranko05
force-pushed
the
gh-50455-time-type-eq
branch
from
bed0480 to
13299bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Comparing
ArrowFormat::Time32TypeandArrowFormat::Time64Typeinstances with the same unit should returntrue.What changes are included in this PR?
Add
ArrowFormat::TimeType#==.Are these changes tested?
Yes.
Added tests for:
Time32TypeTime64TypeAre there any user-facing changes?
Yes.
GitHub Issue: #50455
ArrowFormat::TimeType#==#50455