GH-50360: [Release] Remove stray Apache-Arrow-Flight-SQL-ODBC-*-win64.msi from 04-binary-download.sh and 05-binary-upload.sh#50362
Conversation
…-win64.msi from 04-binary-download.sh and 05-binary-upload.sh
|
|
|
@alinaliBQ @amoeba does this look correct? |
There was a problem hiding this comment.
Pull request overview
This PR updates the release automation scripts to stop downloading/uploading the Flight SQL ODBC Windows MSI in steps 04 and 05, aligning with the newer flow where the MSI is produced later (after signing) by dev/release/07-flightsqlodbc-upload.sh.
Changes:
- Remove the ODBC MSI download pattern from
04-binary-download.sh. - Remove the
UPLOAD_ODBCtoggle and the ODBC MSI upload block from05-binary-upload.sh.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dev/release/04-binary-download.sh | Stops attempting to download Apache-Arrow-Flight-SQL-ODBC-*-win64.msi in step 04. |
| dev/release/05-binary-upload.sh | Stops attempting to GPG-sign/checksum and upload the ODBC MSI in step 05 (removes UPLOAD_ODBC). |
alinaliBQ
left a comment
alinaliBQ
left a comment
There was a problem hiding this comment.
ty for putting up this PR. I have one minor comment
| --pattern "ubuntu-*.tar.gz" \ | ||
| --pattern "Apache-Arrow-Flight-SQL-ODBC-*-win64.msi" \ | ||
| --repo "${REPOSITORY:-apache/arrow}" \ | ||
| --skip-existing |
There was a problem hiding this comment.
nit - comment # Download Linux packages and ODBC MSI. can be updated as well
github-actions
Bot
added
awaiting review
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit a2ce461. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
When executing
05-binary-upload.shthe process failed because theApache-Arrow-Flight-SQL-ODBC-*-win64.msiisn't present.The process changed and now
dev/release/07-flightsqlodbc-upload.shwill download the following unsigned file:arrow_flight_sql_odbc_unsigned.dll from the GitHub release, sign and generated the
Apache-Arrow-Flight-SQL-ODBC-*-win64.msifile.What changes are included in this PR?
Remove trying to download and sign from steps 04 and 05 the ODBC driver msi.
Are these changes tested?
No
Are there any user-facing changes?
No