Skip to content

Commit a2ce461

Browse files
raulcdkou
andauthored
GH-50360: [Release] Remove stray Apache-Arrow-Flight-SQL-ODBC-*-win64.msi from 04-binary-download.sh and 05-binary-upload.sh (#50362)
### Rationale for this change When executing `05-binary-upload.sh` the process failed because the `Apache-Arrow-Flight-SQL-ODBC-*-win64.msi` isn't present. The process changed and now `dev/release/07-flightsqlodbc-upload.sh` will download the following unsigned file: [arrow_flight_sql_odbc_unsigned.dll](https://github.com/apache/arrow/releases/download/untagged-f0e9f29aea11207ee944/arrow_flight_sql_odbc_unsigned.dll) from the GitHub release, sign and generated the `Apache-Arrow-Flight-SQL-ODBC-*-win64.msi` file. ### What changes are included in this PR? Remove trying to download and sign from steps 04 and 05 the ODBC driver msi. ### Are these changes tested? No ### Are there any user-facing changes? No * GitHub Issue: #50360 Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
1 parent 43e2bbe commit a2ce461

2 files changed

Lines changed: 1 addition & 7 deletions

File tree

dev/release/04-binary-download.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,14 +46,13 @@ tag="apache-arrow-${version_with_rc}"
4646

4747
archery crossbow download-artifacts --no-fetch ${CROSSBOW_JOB_ID} "$@"
4848

49-
# Download Linux packages and ODBC MSI.
49+
# Download Linux packages.
5050
gh release download "${tag}" \
5151
--dir "packages/${CROSSBOW_JOB_ID}" \
5252
--pattern "almalinux-*.tar.gz" \
5353
--pattern "amazon-linux-*.tar.gz" \
5454
--pattern "centos-*.tar.gz" \
5555
--pattern "debian-*.tar.gz" \
5656
--pattern "ubuntu-*.tar.gz" \
57-
--pattern "Apache-Arrow-Flight-SQL-ODBC-*-win64.msi" \
5857
--repo "${REPOSITORY:-apache/arrow}" \
5958
--skip-existing

dev/release/05-binary-upload.sh

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ cd "${SOURCE_DIR}"
6767
: "${UPLOAD_CENTOS:=${UPLOAD_DEFAULT}}"
6868
: "${UPLOAD_DEBIAN:=${UPLOAD_DEFAULT}}"
6969
: "${UPLOAD_DOCS:=${UPLOAD_DEFAULT}}"
70-
: "${UPLOAD_ODBC:=${UPLOAD_DEFAULT}}"
7170
: "${UPLOAD_PYTHON:=${UPLOAD_DEFAULT}}"
7271
: "${UPLOAD_R:=${UPLOAD_DEFAULT}}"
7372
: "${UPLOAD_UBUNTU:=${UPLOAD_DEFAULT}}"
@@ -109,10 +108,6 @@ upload_to_github_release() {
109108
if [ "${UPLOAD_DOCS}" -gt 0 ]; then
110109
upload_to_github_release docs "${ARROW_ARTIFACTS_DIR}"/*-docs/*
111110
fi
112-
if [ "${UPLOAD_ODBC}" -gt 0 ]; then
113-
upload_to_github_release odbc \
114-
"${ARROW_ARTIFACTS_DIR}"/Apache-Arrow-Flight-SQL-ODBC-*-win64.msi
115-
fi
116111
if [ "${UPLOAD_PYTHON}" -gt 0 ]; then
117112
upload_to_github_release python \
118113
"${ARROW_ARTIFACTS_DIR}"/{python-sdist,wheel-*}/*

0 commit comments

Comments
 (0)