Skip to content

[v3-3-test] Move known_airflow_exceptions.txt out of scripts/ into generated/ (#69057) #69060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 2 commits into
base: v3-3-test
Choose a base branch
from
+5 −5
Open

[v3-3-test] Move known_airflow_exceptions.txt out of scripts/ into generated/ (#69057) #69060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d07ec08
[v3-3-test] Move known_airflow_exceptions.txt out of scripts/ into ge…
potiuk Jun 26, 2026
3053105
Merge branch 'v3-3-test' into backport-78263d0-v3-3-test
vatsrahul1001 Jun 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 scripts/ci/prek/known_airflow_exceptions.txt → generated/known_airflow_exceptions.txt
View file
Open in desktop
File renamed without changes.
10 changes: 5 additions & 5 deletions scripts/ci/prek/check_new_airflow_exception_usage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
# ///
"""Check that no new ``raise AirflowException`` usages are introduced.

All *existing* usages are recorded in ``known_airflow_exceptions.txt`` next to
this script as ``relative/path::N`` entries (one per file), where ``N`` is the
All *existing* usages are recorded in ``generated/known_airflow_exceptions.txt``
as ``relative/path::N`` entries (one per file), where ``N`` is the
maximum number of ``raise AirflowException`` occurrences allowed in that file.
A file whose current count exceeds the recorded limit is treated as a violation
– use a dedicated exception class instead.
Expand All @@ -36,7 +36,7 @@
When a file's count has *decreased*, the allowlist entry is tightened
automatically and the hook exits with a non-zero code so that pre-commit
reports the modified allowlist — just stage
``scripts/ci/prek/known_airflow_exceptions.txt`` and re-run.
``generated/known_airflow_exceptions.txt`` and re-run.

``--all-files``:
Walk the whole repository and check every ``.py`` file.
Expand Down Expand Up @@ -201,7 +201,7 @@ def _check_airflow_exception_usage(
"If this usage is intentional and pre-existing, run:\n\n"
" [cyan]uv run ./scripts/ci/prek/check_new_airflow_exception_usage.py --generate[/cyan]\n\n"
"to regenerate the allowlist, then commit the updated\n"
"[cyan]scripts/ci/prek/known_airflow_exceptions.txt[/cyan].",
"[cyan]generated/known_airflow_exceptions.txt[/cyan].",
title="[red]❌ Check failed[/red]",
border_style="red",
)
Expand Down Expand Up @@ -239,7 +239,7 @@ def main(argv: list[str] | None = None) -> int:
)
args = parser.parse_args(argv)

manager = AllowlistManager(Path(__file__).parent / "known_airflow_exceptions.txt")
manager = AllowlistManager(REPO_ROOT / "generated" / "known_airflow_exceptions.txt")

if args.generate:
return manager.generate()
Expand Down