[v3-3-test] Move known_airflow_exceptions.txt out of scripts/ into generated/ (#69057)#69060
Open
github-actions[bot] wants to merge 1 commit into
Open
[v3-3-test] Move known_airflow_exceptions.txt out of scripts/ into generated/ (#69057)#69060github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…nerated/ (#69057) The check-no-new-airflow-exceptions hook keeps its allowlist baseline in scripts/ci/prek/known_airflow_exceptions.txt. That file is touched by any PR that legitimately adds, removes, or moves a raise AirflowException -- typically provider or core changes that have nothing to do with dev tooling. Because it lived under scripts/, boring-cyborg matched it against the scripts/**/* glob and auto-applied area:dev-tools and, worse, backport-to-v3-3-test, triggering wrong automated backports of unrelated provider PRs. Move the generated allowlist to generated/known_airflow_exceptions.txt, which no boring-cyborg rule matches, so editing it no longer looks like a dev-tools change. The hook script reads/writes it from the repo-root generated/ directory; .txt files carry no license header, so nothing else changes. (cherry picked from commit 78263d0) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
1 task
potiuk
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl and
potiuk
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check-no-new-airflow-exceptions hook keeps its allowlist baseline in
scripts/ci/prek/known_airflow_exceptions.txt. That file is touched by any PR
that legitimately adds, removes, or moves a raise AirflowException -- typically
provider or core changes that have nothing to do with dev tooling. Because it
lived under scripts/, boring-cyborg matched it against the scripts/**/* glob and
auto-applied area:dev-tools and, worse, backport-to-v3-3-test, triggering wrong
automated backports of unrelated provider PRs.
Move the generated allowlist to generated/known_airflow_exceptions.txt, which no
boring-cyborg rule matches, so editing it no longer looks like a dev-tools change.
The hook script reads/writes it from the repo-root generated/ directory; .txt
files carry no license header, so nothing else changes.
(cherry picked from commit 78263d0)
Co-authored-by: Jarek Potiuk jarek@potiuk.com