Skip to content

Small param rename in BaseExecutor and CeleryExecutor #65814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ferruzzi wants to merge 1 commit into from
Closed

Small param rename in BaseExecutor and CeleryExecutor #65814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions airflow-core/src/airflow/executors/base_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,15 +295,15 @@ def _get_workloads_to_schedule(self, open_slots: int) -> list[tuple[WorkloadKey,

return workloads_to_schedule

def _process_workloads(self, workloads: Sequence[ExecutorWorkload]) -> None:
def _process_workloads(self, workload_items: Sequence[ExecutorWorkload]) -> None:
"""
Process the given workloads.

This method must be implemented by subclasses to define how they handle
the execution of workloads (e.g., queuing them to workers, submitting to
external systems, etc.).

:param workloads: List of workloads to process
:param workload_items: List of workloads to process
"""
raise NotImplementedError(f"{type(self).__name__} must implement _process_workloads()")

Expand Down
4 changes: 2 additions & 2 deletions providers/celery/src/airflow/providers/celery/executors/celery_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,15 +173,15 @@ def _process_tasks(self, task_tuples: Sequence[TaskTuple]) -> None:

self._send_workloads(task_tuples_to_send)

def _process_workloads(self, workloads: Sequence[workloads.All]) -> None:
def _process_workloads(self, workload_items: Sequence[workloads.All]) -> None:
# Airflow V3 version -- have to delay imports until we know we are on v3.
from airflow.executors.workloads import ExecuteTask

if AIRFLOW_V_3_2_PLUS:
from airflow.executors.workloads import ExecuteCallback

workloads_to_be_sent: list[WorkloadInCelery] = []
for workload in workloads:
for workload in workload_items:
if isinstance(workload, ExecuteTask):
workloads_to_be_sent.append((workload.ti.key, workload, workload.ti.queue, self.team_name))
elif AIRFLOW_V_3_2_PLUS and isinstance(workload, ExecuteCallback):
Expand Down
Loading