Small param rename in BaseExecutor and CeleryExecutor#65814
Closed
ferruzzi wants to merge 1 commit intoapache:mainfrom
Closed
Small param rename in BaseExecutor and CeleryExecutor#65814ferruzzi wants to merge 1 commit intoapache:mainfrom
ferruzzi wants to merge 1 commit intoapache:mainfrom
Conversation
ferruzzi
requested review from
XD-DENG,
ashb,
dheerajturaga,
hussein-awala,
o-nikolas and
pierrejeambrun
as code owners
boring-cyborg
Bot
added
area:Executors-core
1 task
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most/all of the executors which implemented this needed to import
from airflow.executors import workloadswhich was causing name shadowing and they were working around it bu doingfrom airflow.executors import workloads as wsinstead. It's cleaner and easier to rename the param in a smarter way.Related to:
#62984 (comment)
#63657
#63498
#63454
#63035
#63888
Part of: #62887
cc: @dondaum