AIP-83 Logical date should be required field when triggering run via API #46390
+94
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stronomer/airflow into restore-unique-constraint-logical-date
…que-constraint-logical-date
…stronomer/airflow into restore-unique-constraint-logical-date
…que-constraint-logical-date
…stronomer/airflow into refactor-backfill-reprocess-logic
…omer/airflow into refactor-backfill-reprocess-logic
vatsrahul1001
requested review from
jscheffl,
potiuk,
XD-DENG and
ashb
as code owners
boring-cyborg
bot
added
area:db-migrations
dstandish
reviewed
Feb 4, 2025
Comment on lines
+103
to
+105
| self.dag_run_id = DagRun.generate_run_id( | ||
| DagRunType.MANUAL, self.logical_date if self.logical_date is not None else pendulum.now("UTC") | ||
| ) |
There was a problem hiding this comment.
on the decision doc, question 6 states that when logical date is null, the run id should be generated from run_after + random string.
There was a problem hiding this comment.
Run_id logic is being implemented in PR. I will update this after that change is merged
dstandish
reviewed
Feb 4, 2025
jedcunningham
added
the
AIP-83
airflow/migrations/versions/0032_3_0_0_rename_execution_date_to_logical_date_and_nullable.py
Outdated
Show resolved
Hide resolved
…l-date-as-required-field-to-trigger-dag-api
… of github.com:astronomer/airflow into make-logical-date-as-required-field-to-trigger-dag-api
…l-date-as-required-field-to-trigger-dag-api
… of github.com:astronomer/airflow into make-logical-date-as-required-field-to-trigger-dag-api
pierrejeambrun
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
Looking good from the AIP stand point.
Logic looks good too but I would be more confortable if some AIP-83 owner could double check.
cc: @dstandish @uranusjr
I think we need to wait for #46398 before merging so we don't have to create a new PR afterwards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes:#46188
depends: #46295
API request with the logical date as null
API request with the logical date as not null
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.