Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-38 Add logical date to trigger DagRun form and remove dataInterval #46471

Merged

Conversation

pierrejeambrun
Copy link
Member

@pierrejeambrun pierrejeambrun commented Feb 5, 2025

Closes: #46189

Needs #46390 (to fix linting issue + make the feature functional)

Logical date is optional in the form and will send null to the API. It can be specified to any arbitrary date otherwise:

Example Logical Date not specified

Screenshot 2025-02-11 at 17 36 04
Screenshot 2025-02-11 at 17 32 07

Example Logical Date specified

Screenshot 2025-02-11 at 17 36 44
Screenshot 2025-02-11 at 17 31 44

@pierrejeambrun pierrejeambrun added the AIP-38 Modern Web Application label Feb 5, 2025
@pierrejeambrun pierrejeambrun added this to the Airflow 3.0.0 milestone Feb 5, 2025
@pierrejeambrun pierrejeambrun self-assigned this Feb 5, 2025
@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Feb 5, 2025
@uranusjr
Copy link
Member

Can we have some frontend magic to help user fill the fields since they are related to each other most of the time? Say

  • If data interval fields are empty, fill them with logical date if it’s filled
  • If logical date field is empty, fill it with data interval end or start if available (in this order)

@pierrejeambrun pierrejeambrun force-pushed the 46189-logical-date-trigger-dag-run-form branch from 35aebc1 to 88b86d8 Compare February 11, 2025 11:45
@pierrejeambrun pierrejeambrun force-pushed the 46189-logical-date-trigger-dag-run-form branch from 88b86d8 to 7237fde Compare February 11, 2025 12:58
@pierrejeambrun
Copy link
Member Author

Can we have some frontend magic to help user fill the fields since they are related to each other most of the time? Say

If data interval fields are empty, fill them with logical date if it’s filled
If logical date field is empty, fill it with data interval end or start if available (in this order)

It appears that we want to completely get rid of the dataIntervalStart and dataIntervalEnd in the trigger form. Updated accordingly in my last commit.

cc: @cmarteepants

@pierrejeambrun pierrejeambrun force-pushed the 46189-logical-date-trigger-dag-run-form branch from 7a5648d to a97d315 Compare February 11, 2025 16:35
@pierrejeambrun pierrejeambrun changed the title AIP-38 Add logical date to trigger DagRun form AIP-38 Add logical date to trigger DagRun form and remove dataInterval Feb 11, 2025
@bbovenzi bbovenzi merged commit c490605 into apache:main Feb 11, 2025
35 checks passed
@bbovenzi bbovenzi deleted the 46189-logical-date-trigger-dag-run-form branch February 11, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AIP-38 Modern Web Application area:UI Related to UI/UX. For Frontend Developers.
Projects
Development

Successfully merging this pull request may close these issues.

AIP-83 when triggering run via new UI, default null, but give a date picker
3 participants