Skip to content

don't include cythonized cpp files #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025
Merged

Conversation

tpgillam
Copy link
Collaborator

@tpgillam tpgillam commented Apr 16, 2025

Modify MANIFEST.in to skip including cython/*.cpp files in the sdist, which are autogenerated.

I've also checked that the wheels don't include these files too, after this change.

@blankjul observed here that binary files are larger than before. After this change:

  • the sdist is much smaller, since its size was dominated by the intermediate cpp files that we shouldn't include
  • the wheels are about the same size, because their size is dominated by shared object files. the file sizes seem similar to the sizes listed on https://pypi.org/project/pymoo/#files . Smaller differences (especially on linux wheels) could be down to us now building on manylinux, possibly?

@tpgillam tpgillam self-assigned this Apr 16, 2025
@tpgillam tpgillam marked this pull request as ready for review April 16, 2025 16:47
@tpgillam tpgillam requested a review from blankjul April 16, 2025 16:47
@tpgillam
Copy link
Collaborator Author

@blankjul a gentle nudge if you have a moment please? Thanks!

(Apologies if this is bothersome; I'm generally accustomed to working in environments where reviews are required before merging, so I will default to this approach.)

@tpgillam tpgillam mentioned this pull request Apr 29, 2025
1 task
@blankjul blankjul merged commit 2939672 into anyoptimization:main Apr 30, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants