Skip to content

Export elastic ip for tunnel when present. #5820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fwang merged 3 commits into from
Jan 6, 2026
Merged

Export elastic ip for tunnel when present. #5820

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84eaa8f
Export elastic ip for tunnel when present.
gkpln3 May 21, 2025
71c27d4
Merge branch 'dev' of https://github.com/sst/sst into dev
gkpln3 Dec 10, 2025
e538537
Make sure tunnel still works even when using managed nat
gkpln3 Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions platform/src/components/aws/vpc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,14 +680,17 @@ export class Vpc extends Component implements Link.Linkable {
self.registerOutputs({
_tunnel: all([
self.bastionInstance,
self.elasticIps,
self.privateKeyValue,
self._privateSubnets,
self._publicSubnets,
]).apply(
([bastion, privateKeyValue, privateSubnets, publicSubnets]) => {
([bastion, elasticIps, privateKeyValue, privateSubnets, publicSubnets]) => {
if (!bastion) return;
return {
ip: bastion.publicIp,
ip: natInstances.apply((instances) =>
instances.length ? elasticIps[0]?.publicIp : bastion.publicIp,
),
Comment on lines +691 to +693
Copy link

@danielsharvey danielsharvey Jan 6, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Should this be self.instances and included inthe all()? I think the static get case is affected.
  2. I do not think this handles the case where NAT Eip's are specified (https://sst.dev/docs/component/aws/vpc/#nat-ip)
  3. I suggest we add a comment to clarify the managed NAT case (Export elastic ip for tunnel when present. #5820 (comment)) - this is not clear from the code. Actually, more than that - why are the Elastic IPs created in the managed NAT case? And further, this will break the static get case.

username: "ec2-user",
privateKey: privateKeyValue!,
subnets: [...privateSubnets, ...publicSubnets].map(
Expand Down