Export elastic ip for tunnel when present.

[gkpln3]

Solves #5657

[mikecfisher]

Whats the status on this?

[jescalan]

I run into problems with the tunnel every time I update the version of SST and it's very painful to resolve. I am really hoping this might fix it? 🙏

[lputnam2000]

@jescalan Did this fix it for you?

[jackwatters45]

Can confirm this fixed the issue for me. @lputnam2000 @fwang

[brandonin]

Do we know when this will be merged?

[pauljasperdev]

can confirm this

#5657 (comment)

I've been able to fix the issue, see #5820.

works for me also.

I rebased @gkpln3's branch with the current and followed build steps for CLI. I use the executable with current SDK 3.17.10

EDIT: does NOT fix it for me. Apprently, I just had a lucky deploy that time.

[joaquimserafim]

@fwang @lputnam2000 I'm a big fan of SST, by the way —it's made my life so much easier overall! will this PR resolve the issue? Every time I'm using SST with RDS, I need to revert to an old version to connect through the tunnel — it's cumbersome and not the best practice. do you have more info on this tunnel issue and when it might be fixed?

[jamesgibbons92]

@gkpln3 Small change needed to this PR before we can merge, the change you proposed breaks the tunnel when using managed nat. In this case, the IP has to be the bastion ec2 instance public ip address not the elastic ips - which are still created, as they are associated to the nat gateways.
Something like this should work I think:

              ip: natInstances.apply((instances) =>
                instances.length ? elasticIps[0]?.publicIp : bastion.publicIp,
              ),

If you're able to make this change I will push to get this merged

[JohnCashmore]

@gkpln3 Small change needed to this PR before we can merge, the change you proposed breaks the tunnel when using managed nat. In this case, the IP has to be the bastion ec2 instance public ip address not the elastic ips - which are still created, as they are associated to the nat gateways. Something like this should work I think:

              ip: natInstances.apply((instances) =>
                instances.length ? elasticIps[0]?.publicIp : bastion.publicIp,
              ),

If you're able to make this change I will push to get this merged

@jamesgibbons92 I've opened a new pull request #6273 with this change and you're suggestion, they work well, sooner this goes in the better end up manually modifying the file every time i need to do a db migration etc.

Closed this now since the original author has made the change

[gkpln3]

@jackwatters45 Done.

[jamesgibbons92]

LGTM, tested the 3 combinations of ec2 nat, managed nat and no nat with the bastion and tunnel is working correctly:

[gkpln3]

Lets merge this?

[danielsharvey]

1. Should this be self.instances and included inthe all()? I think the static get case is affected.
2. I do not think this handles the case where NAT Eip's are specified (https://sst.dev/docs/component/aws/vpc/#nat-ip)
3. I suggest we add a comment to clarify the managed NAT case (Export elastic ip for tunnel when present. #5820 (comment)) - this is not clear from the code. Actually, more than that - why are the Elastic IPs created in the managed NAT case? And further, this will break the static get case.