Skip to content

fix(desktop): move platform creation before event listener #8656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jerome-benoit wants to merge 2 commits into from
Closed

fix(desktop): move platform creation before event listener #8656

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e4c53c
fix(desktop): move platform creation before event listener
jerome-benoit Jan 15, 2026
d6fb20f
wrap createSignal in createRoot for proper lifecycle management
jerome-benoit Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/desktop/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,9 @@ root?.addEventListener("mousewheel", (e) => {
e.stopPropagation()
})

const [serverPassword, setServerPassword] = createSignal<string | null>(null)
const platform = createPlatform(() => serverPassword())

// Handle external links - open in system browser instead of webview
document.addEventListener("click", (e) => {
const link = (e.target as HTMLElement).closest("a.external-link") as HTMLAnchorElement | null
Expand All @@ -302,9 +305,6 @@ document.addEventListener("click", (e) => {
})

render(() => {
const [serverPassword, setServerPassword] = createSignal<string | null>(null)
const platform = createPlatform(() => serverPassword())

return (
<PlatformProvider value={platform}>
<AppBaseProviders>
Expand Down
Loading