fix(desktop): move platform creation before event listener #8656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes typecheck error introduced in anomalyco#7360 where platform.openLink() was referenced before platform was defined. Move platform and serverPassword creation outside render() so they're available to the click event listener.
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a TypeScript compilation error introduced in PR #7360 where platform.openLink() was referenced in an event listener before platform was defined. The solution moves the creation of platform and serverPassword signal outside the render() function to module scope.
Changes:
- Move
createSignalcall forserverPasswordfrom insiderender()to module scope - Move
createPlatform()call from insiderender()to module scope
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
LGTM! |
Contributor
Author
|
fixed in dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes typecheck error
TS2304: Cannot find name 'platform'introduced in #7360.Moves
platformandserverPasswordcreation outsiderender()so they're available to the click event listener that referencesplatform.openLink().Fixes #8657
How did you verify your code works?
bun run typecheck