Fix drop_nulls not passing a Selector type as subset argument #117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest release (0.21.0) has a bug that breaks
DataFrame#drop_nullswhen used with asubsetargument:This comes from the following change in type signature in polars:
pola-rs/polars@8a961cd#diff-744a743b5337b77c8e26e0efabdfe8410bfd77e3d1e55ffa54eb0f29cc51e33bR1904
So we just need to apply the same change that was done in py-polars here:
pola-rs/polars@8a961cd#diff-6f7ee6a0f7f99cb158f4d68d883a118b9fab6175602e8696739d900c8b0d864fR7399