Skip to content

Conversation

@jeromepl
Copy link
Contributor

@jeromepl jeromepl commented Aug 4, 2025

While investigating #117 I found that the #drop_nans method was missing.
It's implementation is basically identical as #drop_nulls, which made this an easy addition.

@ankane
Copy link
Owner

ankane commented Aug 4, 2025

Hi @jeromepl, thanks for another PR! Please make the docs and examples consistent with the Python library.

@jeromepl
Copy link
Contributor Author

jeromepl commented Aug 5, 2025

@ankane the docstring examples have been updated to match py-polars

@jeromepl
Copy link
Contributor Author

jeromepl commented Aug 5, 2025

There are a couple more examples in py-polars, but that don't test the drop_nans method. They are there only for documentation to show how to get similar behaviour using other Polars methods. I omitted them here, but let me know if they should be added

@ankane
Copy link
Owner

ankane commented Aug 5, 2025

Thanks @jeromepl, looks great. There's a conflict after merging #117, but can merge once that's resolved.

@jeromepl jeromepl force-pushed the add-drop_nans-method branch from abec333 to 70072b8 Compare August 5, 2025 19:22
@jeromepl jeromepl force-pushed the add-drop_nans-method branch from 70072b8 to ae5a782 Compare August 5, 2025 19:24
@jeromepl
Copy link
Contributor Author

jeromepl commented Aug 5, 2025

@ankane rebase complete!

@ankane ankane merged commit c9839f1 into ankane:master Aug 5, 2025
@ankane
Copy link
Owner

ankane commented Aug 5, 2025

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants