refactor(core): 从基类分离 dom 实现的底栏和间奏点 - #588
Merged
apoint123 merged 1 commit intoAug 16, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Decouples DOM-specific bottom-line and interlude-dot rendering from the lyric-player base.
Changes:
- Adds abstract component interfaces and factory hooks.
- Moves DOM rendering into dedicated implementations.
- Centralizes lifecycle handling and updates animation behavior.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
packages/core/src/lyric-player/base/bottom-line.ts |
Defines the bottom-line interface. |
packages/core/src/lyric-player/base/interlude-dots.ts |
Defines the interlude-dot interface. |
packages/core/src/lyric-player/base/index.ts |
Adds factories and shared lifecycle handling. |
packages/core/src/lyric-player/dom/bottom-line.ts |
Implements the DOM bottom line. |
packages/core/src/lyric-player/dom/interlude-dots.ts |
Implements and adjusts DOM interlude animation. |
packages/core/src/lyric-player/dom/index.ts |
Supplies DOM component factories. |
packages/core/src/index.ts |
Exposes the runtime spring namespace. |
.nx/version-plans/version-plan-1786893788472.md |
Declares the release increment. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
apoint123
deleted the
refactor/split-dom-interlude-and-bottom-line-from-base
branch
August 16, 2026 15:31
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
让基类和 dom 实现更解耦一些