Skip to content

refactor(core): 从基类分离 dom 实现的底栏和间奏点 - #588

Merged
apoint123 merged 1 commit into
mainfrom
refactor/split-dom-interlude-and-bottom-line-from-base
Aug 16, 2026
Merged

refactor(core): 从基类分离 dom 实现的底栏和间奏点#588
apoint123 merged 1 commit into
mainfrom
refactor/split-dom-interlude-and-bottom-line-from-base

Conversation

@apoint123

Copy link
Copy Markdown
Member

让基类和 dom 实现更解耦一些

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Decouples DOM-specific bottom-line and interlude-dot rendering from the lyric-player base.

Changes:

  • Adds abstract component interfaces and factory hooks.
  • Moves DOM rendering into dedicated implementations.
  • Centralizes lifecycle handling and updates animation behavior.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/core/src/lyric-player/base/bottom-line.ts Defines the bottom-line interface.
packages/core/src/lyric-player/base/interlude-dots.ts Defines the interlude-dot interface.
packages/core/src/lyric-player/base/index.ts Adds factories and shared lifecycle handling.
packages/core/src/lyric-player/dom/bottom-line.ts Implements the DOM bottom line.
packages/core/src/lyric-player/dom/interlude-dots.ts Implements and adjusts DOM interlude animation.
packages/core/src/lyric-player/dom/index.ts Supplies DOM component factories.
packages/core/src/index.ts Exposes the runtime spring namespace.
.nx/version-plans/version-plan-1786893788472.md Declares the release increment.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .nx/version-plans/version-plan-1786893788472.md
@apoint123
apoint123 merged commit 1353646 into main Aug 16, 2026
3 checks passed
@apoint123
apoint123 deleted the refactor/split-dom-interlude-and-bottom-line-from-base branch August 16, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants