Skip to content

refactor(core): 统一时间单位 - #589

Merged
apoint123 merged 1 commit into
mainfrom
refactor/unify-time-units
Aug 17, 2026
Merged

refactor(core): 统一时间单位#589
apoint123 merged 1 commit into
mainfrom
refactor/unify-time-units

Conversation

@apoint123

Copy link
Copy Markdown
Member

引入了一个新的 DurationMediaTime 类型,避免到处传递不清不楚的 number 作为时间

TARGET_BREATHE_DURATION1500 改为 4500 是因为 #588 不小心在这里加了 * Math.PI 修复了数学公式问题,导致每次呼吸时长缩水了 1/π,顺手在这里修了

				scale *=
					Math.sin(
						1.5 * Math.PI - (currentDuration / breatheDuration) * 2 * Math.PI,
					) /
						20 +
					1;

同时移除了没有被使用的几个文件,这样就不用改动里面的时间单位了

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

统一核心模块的时间类型与单位,降低毫秒、秒和时间点混用的风险。

Changes:

  • 新增 DurationMediaTime 及类型/运行时测试。
  • 将歌词时间线、动画、滚动逻辑迁移至新类型。
  • 修复间奏呼吸周期并移除未使用工具。

Reviewed changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.nx/version-plans/version-plan-1786948536412.md 添加版本计划
packages/core/tsconfig.json 纳入测试类型检查
packages/core/test/time.test.ts 测试时间运算
packages/core/test/time.assert-types.ts 验证类型约束
packages/core/src/utils/time.ts 实现时间类型
packages/core/src/utils/spring.ts 统一弹簧时长参数
packages/core/src/utils/wa-spring.ts 删除未使用工具
packages/core/src/utils/schedule.ts 删除未使用工具
packages/core/src/utils/linear.ts 删除未使用工具
packages/core/src/lyric-player/base/timeline.ts 类型化时间线
packages/core/src/lyric-player/base/scroll.ts 规范滚动计时
packages/core/src/lyric-player/base/index.ts 转换播放器时间边界
packages/core/src/lyric-player/base/group.ts 类型化组动画
packages/core/src/lyric-player/base/line.ts 类型化行动画
packages/core/src/lyric-player/base/interlude-dots.ts 更新间奏接口
packages/core/src/lyric-player/base/bottom-line.ts 更新底栏接口
packages/core/src/lyric-player/dom/index.ts 传递统一时长
packages/core/src/lyric-player/dom/lyric-group.ts 更新组实现
packages/core/src/lyric-player/dom/lyric-line.ts 更新行实现
packages/core/src/lyric-player/dom/interlude-dots.ts 修复呼吸周期并迁移时间类型
packages/core/src/lyric-player/dom/bottom-line.ts 更新底栏实现
packages/core/src/index.ts 导出时间 API
packages/docs/src/components/ApiTester/trigger.css 格式化样式

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .nx/version-plans/version-plan-1786948536412.md
@apoint123
apoint123 merged commit 019a2ca into main Aug 17, 2026
3 checks passed
@apoint123
apoint123 deleted the refactor/unify-time-units branch August 17, 2026 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants