feat: ✨ Add server_mock #2993
Draft
feat: ✨ Add server_mock #2993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to create a mock server. This has the benefit of testing the client using a mac, and also in the future it could be used to create a end-to-end server/client core logic testing suite (currently this is blocked by conflicting ports between client and server).
Anther benefit of this PR is laying the ground for Monado support. I've used the simpler approach of using build-time flags for backend selection.
Unfortunately the mock server is not useful yet, as audio doesn't work on the mac (the cpal/rodio mic recording logic on server uses loopback with is windows-only) and also video doesn't work, which might be related to a initialization race condition (which we have on stable) + inability to generate IDRs when using a predownloaded mp4. But I would merge this as is for now.