-
-
Notifications
You must be signed in to change notification settings - Fork 576
Add SteamVR offline launch feature #2994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Here's the difference in sartup speed of SteamVR: Original: Recording.2025-08-22.010233.a.mp4Quick Launch: Recording.2025-08-22.010411.b.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that we are about to change these parts of the code soon, in #2993. I would say to merge that PR after this one.
|
I'm aware of the graphical bugs. We use egui, which is an immediate mode GUI library. egui is the most popular egui library for Rust, but also it moves quite fast, often rewriting the internals completely. Its theming engine is quite weak and pretty buggy, which is what you see as misalignments with the controls (using the default margins it would not produce the same misalignments). Moreover, the weirdness of the layout is caused by egui being an immediate mode gui. Immediate mode means that the library cannot produce the functionality of flexbox, centering, anything that requires knowledge of what will be drawn next (egui actually tries to be smart when using built-in controls but there are pitfalls everywhere). Despite all of these issues, we decided to go with egui because it will allow to embed the dashboard or part of it inside the client, as it has an easy to integrate WGPU backend. I'd life if you could give a look at the GUI code. There are definitely quite a few things that can be fixed, and also maybe bugs that can be reported to egui upstream. |
|
Awesome! I'll probably look at the UI code later and I'll do another pull request once I've implemented some proper design tweaks. I've been using the build with the Quick Launch feature now and it works great. I think it's all ready to be integrated into ALVR for the next release. Thank you very much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the thing I highlighted. It would also be great if you could fix the nitpicks too, because every improvement to code quality is great, but it's also fine if some of those are too much for you to handle.
|
My apologies for the delay, I wasn't home for a couple days but I got back and applied the requested changes. I hope it's a bit better, let me know if I missed some things. Have a nice day! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I forgot to publish my review a few days ago
|
No problem. I fixed it. |
|
@Iemand005 No other comments from me. Fix the last nit from ThePersonifiedDevil and we can merge |
|
My apologies, I had somehow missed that comment. I changed it and simplified the launching logic a bit. I also moved the error out of the utility function as you suggested. I hope it's better like this, I tested it on Windows, fallback works fine too. Thank you very much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code in launch_steamvr() was fine as before without rewriting more stuff. You should fix the comments or just revert the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good enough i think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine for now, there's some small cleanup things I want to change but I don't want to drag this on even more with confusing review comments, so I'll just make a follow up PR in the next couple of days.



Added a toggle to choose to directly start SteamVR instead of using the steam protocol.
Benefits:
Drawbacks:
I really wanted an easier way to launch SteamVR this way, it's annoying to have to use a shortcut to the executable and having the automatic restart in ALVR launch Steam. Enabling this greatly improves the experience by removing the wait for SteamVR to launch. If there's stuff you'd like changed just let me know. I'll provide support and updates for the feature must there be bugs or issues with it.
Thank you very much!