Skip to content

feat: Allow use v2 API for Trade events SSE endpoint #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dtatarkin
Copy link
Contributor

There is a new endpoint https://broker-api.sandbox.alpaca.markets/v2/events/trades that should be used for new integrations.

The motivation for this pull request is to add the ability to use the new v2 endpoint while continue using the v1 versions for other endpoints, and to maintain backwards compatibility with existing code. Enables iterative upgrades for existing customers.

@dtatarkin dtatarkin requested a review from hiohiohio as a code owner April 17, 2025 20:04
@dtatarkin dtatarkin force-pushed the feat-v2-trade-events branch from 6fb364c to de2466c Compare April 18, 2025 22:56
@hiohiohio
Copy link
Contributor

Thank you for the PR.
Discussion: I might think to introduce a new method instead of extending existing one as we prefer to deprecate v1 sse endpoint and also as far as I understand there are some gaps between v1 and v2. Therefore, seamless transition for client might not be possible? In that case, I feel changing default version with existing method makes some issue in runtime rather than static analysis. If we introduced a new method, it might give a chance to catch the change by the static analysis before runtime when we removed existing method.

Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label May 20, 2025
Copy link

This PR was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants