feat: Allow str values for since_id in GetEventsRequest model
#587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equest` to handle ULID id types
hiohiohio
reviewed
Apr 21, 2025
Comment on lines
+990
to
+991
| since_id: Optional[Union[int, str]] = None | ||
| until_id: Optional[Union[int, str]] = None |
There was a problem hiding this comment.
Thank you for this PR. I have commented similar to the other PR: #588 (comment) .
I feel this change might make us hard to remove a method calling deprecated API endpoint. Therefore, prefer to have separate set of method/request/response models instead of making existing one compatible. It is hard to migrate to a new version seamlessly. Therefore, prefer to provide a chance to notice of deprecated method/request/response models for the upcoming removing of them.
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
strvalues forsince_idanduntil_idinGetEventsRequestto handle ULID id types.E.g. endpoint https://broker-api.sandbox.alpaca.markets/v2/events/trades requires string as
since_idanduntil_idquery params